Index: trunk/doc/TODO =================================================================== --- trunk/doc/TODO (revision 23381) +++ trunk/doc/TODO (revision 23382) @@ -23,7 +23,6 @@ 1. For the upcoming release =============================================================================== - BUG: scconfig: core gets glib dependency even if everything is in plugins (only plugins depend on glib) [report: Vuokko] - BUG: font bbox xor draw appears on wrong coords (on top) [report: Igor2] -- CLEANUP: search for TODO pcb_has_explicit_outline() [report: Igor2] - CLEANUP/BUG: lesstif: preferences(layers): EXPFILL doesn't seem to work; need to replace box code with work/lkesstif/formbox [report: Igor2] - BUG: lesstif: {i c p}, color tab: tabbed doesn't grow [report: Igor2] - CAM: Index: trunk/src_plugins/export_gerber/gerber.c =================================================================== --- trunk/src_plugins/export_gerber/gerber.c (revision 23381) +++ trunk/src_plugins/export_gerber/gerber.c (revision 23382) @@ -744,14 +744,7 @@ want_cross_sect = options[HA_cross_sect].int_value; -TODO("use pcb_has_explicit_outline() instead") - has_outline = 0; - for(i = 0, g = PCB->LayerGroups.grp; i < PCB->LayerGroups.len; i++,g++) { - if (PCB_LAYER_IS_OUTLINE(g->ltype, g->purpi)) { - has_outline = 1; - break; - } - } + has_outline = pcb_has_explicit_outline(PCB); i = strlen(fnbase); filename = (char *) realloc(filename, i + SUFF_LEN); Index: trunk/src_plugins/export_openems/export_openems.c =================================================================== --- trunk/src_plugins/export_openems/export_openems.c (revision 23381) +++ trunk/src_plugins/export_openems/export_openems.c (revision 23382) @@ -336,7 +336,7 @@ fprintf(ctx->f, "%%%%%% Board outline\n"); -TODO("use pcb_has_explicit_outline() instead") +TODO("layer: consider multiple outline layers instead") out1 = pcb_topoly_find_1st_outline(ctx->pcb); if (out1 != NULL) { long n; Index: trunk/src_plugins/export_ps/ps.c =================================================================== --- trunk/src_plugins/export_ps/ps.c (revision 23381) +++ trunk/src_plugins/export_ps/ps.c (revision 23382) @@ -662,15 +662,7 @@ global.scale_factor *= MIN(zx, zy); } -TODO("use pcb_has_explicit_outline() instead") - global.has_outline = 0; - for(i = 0, g = PCB->LayerGroups.grp; i < PCB->LayerGroups.len; i++,g++) { - if (PCB_LAYER_IS_OUTLINE(g->ltype, g->purpi) && !pcb_layergrp_is_pure_empty(PCB, i)) { - global.has_outline = 1; - break; - } - } - + global.has_outline = pcb_has_explicit_outline(PCB); memcpy(saved_layer_stack, pcb_layer_stack, sizeof(pcb_layer_stack)); qsort(pcb_layer_stack, pcb_max_layer, sizeof(pcb_layer_stack[0]), layer_sort); Index: trunk/src_plugins/io_hyp/write.c =================================================================== --- trunk/src_plugins/io_hyp/write.c (revision 23381) +++ trunk/src_plugins/io_hyp/write.c (revision 23382) @@ -367,17 +367,7 @@ fprintf(wr->f, "{BOARD\n"); -TODO("use pcb_has_explicit_outline() instead") - has_outline = 0; - for(i = 0, g = PCB->LayerGroups.grp; i < PCB->LayerGroups.len; i++,g++) { - if (pcb_layergrp_is_pure_empty(PCB, i)) - continue; - if (PCB_LAYER_IS_OUTLINE(g->ltype, g->purpi)) { - has_outline = 1; - break; - } - } - + has_outline = pcb_has_explicit_outline(PCB); if (!has_outline) { /* implicit outline */ fprintf(wr->f, "* implicit outline derived from board width and height\n"); Index: trunk/src_plugins/io_kicad/write.c =================================================================== --- trunk/src_plugins/io_kicad/write.c (revision 23381) +++ trunk/src_plugins/io_kicad/write.c (revision 23382) @@ -939,11 +939,8 @@ fixed_layer_t *l; pcb_layergrp_t *g; -TODO("use pcb_has_explicit_outline() instead") - /* if any outline layer is non-empty, don't draw the implicit outline */ - for(i = 0, g = ctx->pcb->LayerGroups.grp; i < ctx->pcb->LayerGroups.len; i++,g++) - if ((PCB_LAYER_IS_OUTLINE(g->ltype, g->purpi)) && (!pcb_layergrp_is_pure_empty(ctx->pcb, i))) - return; + if (pcb_has_explicit_outline(ctx->pcb)) + return; /* find the first kicad outline layer */ for(l = fixed_layers; l->name != NULL; l++) {