Index: trunk/doc-rnd/hacking/renames =================================================================== --- trunk/doc-rnd/hacking/renames (revision 4949) +++ trunk/doc-rnd/hacking/renames (revision 4950) @@ -558,3 +558,6 @@ CreateNewElement -> pcb_element_new CreateNewArcInElement -> pcb_element_arc_new CreateNewLineInElement -> pcb_element_line_new +RemoveElement -> pcb_element_remove +MoveElementLowLevel -> pcb_element_move +MirrorElementCoordinates -> pcb_element_mirror Index: trunk/src/action_helper.c =================================================================== --- trunk/src/action_helper.c (revision 4949) +++ trunk/src/action_helper.c (revision 4950) @@ -1070,7 +1070,7 @@ memcpy(estr, e->Name, MAX_ELEMENTNAMES * sizeof(pcb_text_t)); for (i = 0; i < MAX_ELEMENTNAMES; ++i) estr[i].TextString = estr[i].TextString ? pcb_strdup(estr[i].TextString) : NULL; - RemoveElement(e); + pcb_element_remove(e); } } } Index: trunk/src/buffer.c =================================================================== --- trunk/src/buffer.c (revision 4949) +++ trunk/src/buffer.c (revision 4950) @@ -468,7 +468,7 @@ ELEMENT_LOOP(Buffer->Data); { r_delete_element(Buffer->Data, element); - MirrorElementCoordinates(Buffer->Data, element, 0); + pcb_element_mirror(Buffer->Data, element, 0); } END_LOOP; /* set buffer offset to 'mark' position */ Index: trunk/src/obj_elem.c =================================================================== --- trunk/src/obj_elem.c (revision 4949) +++ trunk/src/obj_elem.c (revision 4950) @@ -454,7 +454,7 @@ return (pcb_false); EraseElement(Element); AddObjectToMirrorUndoList(PCB_TYPE_ELEMENT, Element, Element, Element, yoff); - MirrorElementCoordinates(PCB->Data, Element, yoff); + pcb_element_mirror(PCB->Data, Element, yoff); DrawElement(Element); return (pcb_true); } @@ -662,7 +662,7 @@ } /* mirrors the coordinates of an element; an additional offset is passed */ -void MirrorElementCoordinates(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t yoff) +void pcb_element_mirror(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t yoff) { r_delete_element(Data, Element); ELEMENTLINE_LOOP(Element); @@ -991,7 +991,7 @@ } /* moves a element by +-X and +-Y */ -void MoveElementLowLevel(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t DX, pcb_coord_t DY) +void pcb_element_move(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t DX, pcb_coord_t DY) { if (Data) r_delete_entry(Data->element_tree, (pcb_box_t *) Element); @@ -1047,7 +1047,7 @@ r_insert_entry(Data->element_tree, (pcb_box_t *) Element, 0); } -void *RemoveElement(pcb_element_t *Element) +void *pcb_element_remove(pcb_element_t *Element) { pcb_opctx_t ctx; @@ -1565,7 +1565,7 @@ if (PCB->ElementOn && (PCB_FRONT(Element) || PCB->InvisibleObjectsOn)) { EraseElement(Element); - MoveElementLowLevel(PCB->Data, Element, ctx->move.dx, ctx->move.dy); + pcb_element_move(PCB->Data, Element, ctx->move.dx, ctx->move.dy); DrawElementName(Element); DrawElementPackage(Element); didDraw = pcb_true; @@ -1573,7 +1573,7 @@ else { if (PCB->PinOn) EraseElementPinsAndPads(Element); - MoveElementLowLevel(PCB->Data, Element, ctx->move.dx, ctx->move.dy); + pcb_element_move(PCB->Data, Element, ctx->move.dx, ctx->move.dy); } if (PCB->PinOn) { DrawElementPinsAndPads(Element); Index: trunk/src/obj_elem.h =================================================================== --- trunk/src/obj_elem.h (revision 4949) +++ trunk/src/obj_elem.h (revision 4950) @@ -81,9 +81,9 @@ char *UniqueElementName(pcb_data_t *Data, char *Name); void r_delete_element(pcb_data_t * data, pcb_element_t * element); -void MoveElementLowLevel(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t DX, pcb_coord_t DY); -void *RemoveElement(pcb_element_t *Element); -void MirrorElementCoordinates(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t yoff); +void pcb_element_move(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t DX, pcb_coord_t DY); +void *pcb_element_remove(pcb_element_t *Element); +void pcb_element_mirror(pcb_data_t *Data, pcb_element_t *Element, pcb_coord_t yoff); pcb_arc_t *pcb_element_arc_new(pcb_element_t *Element, pcb_coord_t X, pcb_coord_t Y, pcb_coord_t Width, pcb_coord_t Height, pcb_angle_t angle, pcb_angle_t delta, pcb_coord_t Thickness); Index: trunk/src/object_act.c =================================================================== --- trunk/src/object_act.c (revision 4949) +++ trunk/src/object_act.c (revision 4950) @@ -276,7 +276,7 @@ dy += PCB->Grid; /* move the element */ - MoveElementLowLevel(PCB->Data, element, dx, dy); + pcb_element_move(PCB->Data, element, dx, dy); /* and add to the undo list so we can undo this operation */ AddObjectToMoveUndoList(PCB_TYPE_ELEMENT, NULL, NULL, element, dx, dy); @@ -599,7 +599,7 @@ er = pcb_element_get_orientation(e); pe = elementlist_first(&(PCB_PASTEBUFFER->Data->Element)); if (!PCB_FRONT(e)) - MirrorElementCoordinates(PCB_PASTEBUFFER->Data, pe, pe->MarkY * 2 - PCB->MaxHeight); + pcb_element_mirror(PCB_PASTEBUFFER->Data, pe, pe->MarkY * 2 - PCB->MaxHeight); pr = pcb_element_get_orientation(pe); mx = e->MarkX; @@ -615,7 +615,7 @@ pe->Name[i].Scale = e->Name[i].Scale; } - RemoveElement(e); + pcb_element_remove(e); if (pcb_buffer_copy_to_layout(mx, my)) SetChangedFlag(pcb_true); Index: trunk/src/rats_patch.c =================================================================== --- trunk/src/rats_patch.c (revision 4949) +++ trunk/src/rats_patch.c (revision 4950) @@ -433,7 +433,7 @@ pcb_load_footprint(3, a, element->MarkX, element->MarkY); pcb_buffer_copy_to_layout(element->MarkX, element->MarkY); rats_patch_append_optimize(PCB, RATP_CHANGE_ATTRIB, a[1], "footprint", fpname); - RemoveElement(element); + pcb_element_remove(element); } } END_LOOP; Index: trunk/src/undo.c =================================================================== --- trunk/src/undo.c (revision 4949) +++ trunk/src/undo.c (revision 4950) @@ -565,7 +565,7 @@ pcb_element_t *element = (pcb_element_t *) ptr3; if (andDraw) EraseElement(element); - MirrorElementCoordinates(PCB->Data, element, Entry->Data.Move.DY); + pcb_element_mirror(PCB->Data, element, Entry->Data.Move.DY); if (andDraw) DrawElement(element); return (pcb_true); Index: trunk/src_plugins/autocrop/autocrop.c =================================================================== --- trunk/src_plugins/autocrop/autocrop.c (revision 4949) +++ trunk/src_plugins/autocrop/autocrop.c (revision 4950) @@ -139,7 +139,7 @@ { ELEMENT_LOOP(PCB->Data); { - MoveElementLowLevel(PCB->Data, element, dx, dy); + pcb_element_move(PCB->Data, element, dx, dy); AddObjectToMoveUndoList(PCB_TYPE_ELEMENT, NULL, NULL, element, dx, dy); } END_LOOP; Index: trunk/src_plugins/autoplace/autoplace.c =================================================================== --- trunk/src_plugins/autoplace/autoplace.c (revision 4949) +++ trunk/src_plugins/autoplace/autoplace.c (revision 4950) @@ -621,7 +621,7 @@ DX = -DX; DY = -DY; } - MoveElementLowLevel(PCB->Data, pt->element, DX, DY); + pcb_element_move(PCB->Data, pt->element, DX, DY); return; } case ROTATE: @@ -634,9 +634,9 @@ pcb_element_rotate90(PCB->Data, pt->element, bbcx, bbcy, b); else { pcb_coord_t y = pt->element->VBox.Y1; - MirrorElementCoordinates(PCB->Data, pt->element, 0); + pcb_element_mirror(PCB->Data, pt->element, 0); /* mirroring moves the element. move it back. */ - MoveElementLowLevel(PCB->Data, pt->element, 0, y - pt->element->VBox.Y1); + pcb_element_move(PCB->Data, pt->element, 0, y - pt->element->VBox.Y1); } return; } @@ -647,8 +647,8 @@ pcb_coord_t y1 = pt->element->VBox.Y1; pcb_coord_t x2 = pt->other->BoundingBox.X1; pcb_coord_t y2 = pt->other->BoundingBox.Y1; - MoveElementLowLevel(PCB->Data, pt->element, x2 - x1, y2 - y1); - MoveElementLowLevel(PCB->Data, pt->other, x1 - x2, y1 - y2); + pcb_element_move(PCB->Data, pt->element, x2 - x1, y2 - y1); + pcb_element_move(PCB->Data, pt->other, x1 - x2, y1 - y2); /* then flip both elements if they are on opposite sides */ if (PCB_FLAG_TEST(PCB_FLAG_ONSOLDER, pt->element) != PCB_FLAG_TEST(PCB_FLAG_ONSOLDER, pt->other)) { PerturbationType mypt; Index: trunk/src_plugins/distalign/distalign.c =================================================================== --- trunk/src_plugins/distalign/distalign.c (revision 4949) +++ trunk/src_plugins/distalign/distalign.c (revision 4950) @@ -431,7 +431,7 @@ dy = 0; else dx = 0; - MoveElementLowLevel(PCB->Data, element, dx, dy); + pcb_element_move(PCB->Data, element, dx, dy); AddObjectToMoveUndoList(PCB_TYPE_ELEMENT, NULL, NULL, element, dx, dy); changed = 1; } @@ -596,7 +596,7 @@ dy = 0; else dx = 0; - MoveElementLowLevel(PCB->Data, element, dx, dy); + pcb_element_move(PCB->Data, element, dx, dy); AddObjectToMoveUndoList(PCB_TYPE_ELEMENT, NULL, NULL, element, dx, dy); changed = 1; } Index: trunk/src_plugins/export_openscad/scadcomp.c =================================================================== --- trunk/src_plugins/export_openscad/scadcomp.c (revision 4949) +++ trunk/src_plugins/export_openscad/scadcomp.c (revision 4950) @@ -363,7 +363,7 @@ -- Copy AddElementToBuffer (pcb_element_t *Element) if (PCB_ON_SIDE(Element,(Settings.ShowBottomSide)?BOTTOM_SIDE:TOP_SIDE)) - MirrorElementCoordinates (element_buffer.Data, element, 0); + pcb_element_mirror(element_buffer.Data, element, 0); pcb_buffer_clear(&element_buffer); */ Index: trunk/src_plugins/hid_gtk/gui-pinout-preview.c =================================================================== --- trunk/src_plugins/hid_gtk/gui-pinout-preview.c (revision 4949) +++ trunk/src_plugins/hid_gtk/gui-pinout-preview.c (revision 4950) @@ -82,7 +82,7 @@ END_LOOP; - MoveElementLowLevel(NULL, &pinout->element, + pcb_element_move(NULL, &pinout->element, conf_core.appearance.pinout.offset_x - pinout->element.BoundingBox.X1, conf_core.appearance.pinout.offset_y - pinout->element.BoundingBox.Y1); Index: trunk/src_plugins/io_pcb/file.c =================================================================== --- trunk/src_plugins/io_pcb/file.c (revision 4949) +++ trunk/src_plugins/io_pcb/file.c (revision 4950) @@ -568,7 +568,7 @@ ParseGroupString("1,c:2,s", &yyPCB->LayerGroups, yyData->LayerN); e = elementlist_first(&yyPCB->Data->Element); /* we know there's only one */ PCB = yyPCB; - MoveElementLowLevel(yyPCB->Data, e, -e->BoundingBox.X1, -e->BoundingBox.Y1); + pcb_element_move(yyPCB->Data, e, -e->BoundingBox.X1, -e->BoundingBox.Y1); PCB = pcb_save; yyPCB->MaxWidth = e->BoundingBox.X2; yyPCB->MaxHeight = e->BoundingBox.Y2; Index: trunk/src_plugins/smartdisperse/smartdisperse.c =================================================================== --- trunk/src_plugins/smartdisperse/smartdisperse.c (revision 4949) +++ trunk/src_plugins/smartdisperse/smartdisperse.c (revision 4950) @@ -83,7 +83,7 @@ } /* move the element */ - MoveElementLowLevel(PCB->Data, element, dx, dy); + pcb_element_move(PCB->Data, element, dx, dy); /* and add to the undo list so we can undo this operation */ AddObjectToMoveUndoList(PCB_TYPE_ELEMENT, NULL, NULL, element, dx, dy);